Sneederix/sneedmc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remove unused parsing of dates (bloat)

Browse Source
This commit is contained in:
dada513 2022-02-10 13:57:18 +01:00
parent d42d6fe25a
commit 13d41bde7f
No known key found for this signature in database
GPG Key ID: 403448C14FA4B33E
2 changed files with 3 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
launcher/news/NewsEntry.cpp
View File

@ -24,18 +24,14 @@ NewsEntry::NewsEntry(QObject* parent) :
this->title = tr("Untitled"); this->title = tr("Untitled");
this->content = tr("No content."); this->content = tr("No content.");
this->link = ""; this->link = "";
this->author = tr("Unknown Author");
this->pubDate = QDateTime::currentDateTime();
} }
NewsEntry::NewsEntry(const QString& title, const QString& content, const QString& link, const QString& author, const QDateTime& pubDate, QObject* parent) : NewsEntry::NewsEntry(const QString& title, const QString& content, const QString& link, QObject* parent) :
QObject(parent) QObject(parent)
{ {
this->title = title; this->title = title;
this->content = content; this->content = content;
this->link = link; this->link = link;
this->author = author;
this->pubDate = pubDate;
} }
/*! /*!
@ -59,19 +55,11 @@ bool NewsEntry::fromXmlElement(const QDomElement& element, NewsEntry* entry, QSt
{ {
QString title = childValue(element, "title", tr("Untitled")); QString title = childValue(element, "title", tr("Untitled"));
QString content = childValue(element, "description", tr("No content.")); QString content = childValue(element, "description", tr("No content."));
QString link = childValue(element, "link"); QString link = childValue(element, "id");
QString author = childValue(element, "dc:creator", tr("Unknown Author"));
QString pubDateStr = childValue(element, "pubDate");
// FIXME: For now, we're just ignoring timezones. We assume that all time zones in the RSS feed are the same.
QString dateFormat("ddd, dd MMM yyyy hh:mm:ss");
QDateTime pubDate = QDateTime::fromString(pubDateStr, dateFormat);
entry->title = title; entry->title = title;
entry->content = content; entry->content = content;
entry->link = link; entry->link = link;
entry->author = author;
entry->pubDate = pubDate;
return true; return true;
} }

10
launcher/news/NewsEntry.h
View File

@ -18,8 +18,6 @@
#include <QObject> #include <QObject>
#include <QString> #include <QString>
#include <QDomElement> #include <QDomElement>
#include <QDateTime>
#include <memory> #include <memory>
class NewsEntry : public QObject class NewsEntry : public QObject
@ -36,7 +34,7 @@ public:
* Constructs a new news entry. * Constructs a new news entry.
* Note that content may contain HTML. * Note that content may contain HTML.
*/ */
NewsEntry(const QString& title, const QString& content, const QString& link, const QString& author, const QDateTime& pubDate, QObject* parent=0); NewsEntry(const QString& title, const QString& content, const QString& link, QObject* parent=0);
/*! /*!
* Attempts to load information from the given XML element into the given news entry pointer. * Attempts to load information from the given XML element into the given news entry pointer.
@ -53,12 +51,6 @@ public:
//! URL to the post. //! URL to the post.
QString link; QString link;
//! The post's author.
QString author;
//! The date and time that this post was published.
QDateTime pubDate;
}; };
typedef std::shared_ptr<NewsEntry> NewsEntryPtr; typedef std::shared_ptr<NewsEntry> NewsEntryPtr;