Rearrange logiv for OneSix version change
This commit is contained in:
parent
4bf1cac8d8
commit
30d4f5981d
@ -1026,22 +1026,9 @@ void MainWindow::on_actionChangeInstMCVersion_triggered()
|
|||||||
VersionSelectDialog vselect(m_selectedInstance->versionList().get(),
|
VersionSelectDialog vselect(m_selectedInstance->versionList().get(),
|
||||||
tr("Change Minecraft version"), this);
|
tr("Change Minecraft version"), this);
|
||||||
vselect.setFilter(1, "OneSix");
|
vselect.setFilter(1, "OneSix");
|
||||||
if (vselect.exec() && vselect.selectedVersion())
|
if(!vselect.exec() || !vselect.selectedVersion())
|
||||||
{
|
return;
|
||||||
if (m_selectedInstance->versionIsCustom())
|
|
||||||
{
|
|
||||||
auto result = CustomMessageBox::selectable(
|
|
||||||
this, tr("Are you sure?"),
|
|
||||||
tr("This will remove any library/version customization you did previously. "
|
|
||||||
"This includes things like Forge install and similar."),
|
|
||||||
QMessageBox::Warning, QMessageBox::Ok | QMessageBox::Abort,
|
|
||||||
QMessageBox::Abort)->exec();
|
|
||||||
|
|
||||||
if (result != QMessageBox::Ok)
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
m_selectedInstance->setIntendedVersionId(vselect.selectedVersion()->descriptor());
|
|
||||||
}
|
|
||||||
if (!MMC->accounts()->anyAccountIsValid())
|
if (!MMC->accounts()->anyAccountIsValid())
|
||||||
{
|
{
|
||||||
CustomMessageBox::selectable(
|
CustomMessageBox::selectable(
|
||||||
@ -1051,7 +1038,22 @@ void MainWindow::on_actionChangeInstMCVersion_triggered()
|
|||||||
QMessageBox::Warning)->show();
|
QMessageBox::Warning)->show();
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
auto updateTask = m_selectedInstance->doUpdate(false /*only_prepare*/);
|
|
||||||
|
if (m_selectedInstance->versionIsCustom())
|
||||||
|
{
|
||||||
|
auto result = CustomMessageBox::selectable(
|
||||||
|
this, tr("Are you sure?"),
|
||||||
|
tr("This will remove any library/version customization you did previously. "
|
||||||
|
"This includes things like Forge install and similar."),
|
||||||
|
QMessageBox::Warning, QMessageBox::Ok | QMessageBox::Abort,
|
||||||
|
QMessageBox::Abort)->exec();
|
||||||
|
|
||||||
|
if (result != QMessageBox::Ok)
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
m_selectedInstance->setIntendedVersionId(vselect.selectedVersion()->descriptor());
|
||||||
|
|
||||||
|
auto updateTask = m_selectedInstance->doUpdate(false);
|
||||||
if (!updateTask)
|
if (!updateTask)
|
||||||
{
|
{
|
||||||
return;
|
return;
|
||||||
|
Loading…
Reference in New Issue
Block a user