From 6bb8332b4b8efbb3f21f31d465fa907c3db0a7ce Mon Sep 17 00:00:00 2001 From: flow Date: Sun, 17 Jul 2022 11:43:12 -0300 Subject: [PATCH] fix: bogus returns in EnsureMetadataTask Signed-off-by: flow --- launcher/modplatform/EnsureMetadataTask.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/launcher/modplatform/EnsureMetadataTask.cpp b/launcher/modplatform/EnsureMetadataTask.cpp index f0c1fa99..60c54c4e 100644 --- a/launcher/modplatform/EnsureMetadataTask.cpp +++ b/launcher/modplatform/EnsureMetadataTask.cpp @@ -96,20 +96,22 @@ void EnsureMetadataTask::executeTask() setStatus(tr("Checking if mods have metadata...")); for (auto* mod : m_mods) { - if (!mod->valid()) + if (!mod->valid()) { + qDebug() << "Mod" << mod->name() << "is invalid!"; + emitFail(mod); continue; + } // They already have the right metadata :o if (mod->status() != ModStatus::NoMetadata && mod->metadata() && mod->metadata()->provider == m_provider) { qDebug() << "Mod" << mod->name() << "already has metadata!"; emitReady(mod); - return; + continue; } // Folders don't have metadata if (mod->type() == Mod::MOD_FOLDER) { emitReady(mod); - return; } }