Sneederix/sneedmc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

GH-1885 make FileSink save (even empty) files when the HTTP response is 200 or 203

Browse Source
This commit is contained in:
Petr Mrázek 2017-05-09 03:08:38 +02:00
parent 8fe18cfabc
commit 8a526fab0e
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
api/logic/net/FileSink.cpp
View File

@ -71,8 +71,18 @@ JobStatus FileSink::abort()
JobStatus FileSink::finalize(QNetworkReply& reply) JobStatus FileSink::finalize(QNetworkReply& reply)
{ {
bool gotFile = false;
QVariant statusCodeV = reply.attribute(QNetworkRequest::HttpStatusCodeAttribute);
bool validStatus = false;
int statusCode = statusCodeV.toInt(&validStatus);
if(validStatus)
{
// this leaves out 304 Not Modified
gotFile = statusCode == 200 || statusCode == 203;
}
// if we wrote any data to the save file, we try to commit the data to the real file. // if we wrote any data to the save file, we try to commit the data to the real file.
if (wroteAnyData) // if it actually got a proper file, we write it even if it was empty
if (gotFile || wroteAnyData)
{ {
// ask validators for data consistency // ask validators for data consistency
// we only do this for actual downloads, not 'your data is still the same' cache hits // we only do this for actual downloads, not 'your data is still the same' cache hits