This ends my series of patches fixing warnings throughout the codebase. Now, there are NO warnings except for unused parameters, tested on GCC 13.1.1 and Clang 16.0.2 with -Wall -Wextra.
Fixed dark mode crashing on Windows 8.1, 8 and 7, and removed a need for an export by moving in the function.
Any people looking at the Windows code and asking why I didn't use official version querying API's, those typically have some sort of unwanted behavior, plus checking exports to determine versions is shorter.
for FileSystem.cpp:
Instead of checking if Linux or FreeBSD, check if its not Windows and not OSX. Chances are other operating systems run a DE that adheres to the XDG Desktop standard (.desktop). The check isn't good enough anyways since alternative shells for Windows exist, it will never be an accurate check. In any case this function is unused.
WorldListPage.cpp:
Redo confusing switch statement plagued with fall throughs, now well defined.
LaunchController.cpp:
Remove cringe. Also fix warning and make the unimplemented case(s) more explicit.
VersionProxyModel.cpp:
Add fallthrough for warning suppression.
WorldListPage.cpp:
redo `mceditState`
TranslationsModel.cpp:
Move up definition of `column` variable to when it is needed, clear up switch cases
FlameInstanceCreationTask.cpp:
Fallthrough intentionally
SkinUpload.cpp:
Make `getVariant`
ResourcePack.cpp:
Add new values for 1.19.3+
meta/Index.cpp:
Make clear switch statement behavior
JavaWizardPage.cpp:
Fix case fallthrough
Yggdrasil.cpp:
Fix case fallthrough
AccountList.cpp:
Fix case fallthrough,
WinDarkmode.cpp:
Add an explanation and fix warnings due to FARPROC casts.
Signed-off-by: jdp_ <42700985+jdpatdiscord@users.noreply.github.com>
