This ends my series of patches fixing warnings throughout the codebase. Now, there are NO warnings except for unused parameters, tested on GCC 13.1.1 and Clang 16.0.2 with -Wall -Wextra.
Fixed dark mode crashing on Windows 8.1, 8 and 7, and removed a need for an export by moving in the function.
Any people looking at the Windows code and asking why I didn't use official version querying API's, those typically have some sort of unwanted behavior, plus checking exports to determine versions is shorter.
for FileSystem.cpp:
Instead of checking if Linux or FreeBSD, check if its not Windows and not OSX. Chances are other operating systems run a DE that adheres to the XDG Desktop standard (.desktop). The check isn't good enough anyways since alternative shells for Windows exist, it will never be an accurate check. In any case this function is unused.
WorldListPage.cpp:
Redo confusing switch statement plagued with fall throughs, now well defined.
LaunchController.cpp:
Remove cringe. Also fix warning and make the unimplemented case(s) more explicit.
VersionProxyModel.cpp:
Add fallthrough for warning suppression.
WorldListPage.cpp:
redo `mceditState`
TranslationsModel.cpp:
Move up definition of `column` variable to when it is needed, clear up switch cases
FlameInstanceCreationTask.cpp:
Fallthrough intentionally
SkinUpload.cpp:
Make `getVariant`
ResourcePack.cpp:
Add new values for 1.19.3+
meta/Index.cpp:
Make clear switch statement behavior
JavaWizardPage.cpp:
Fix case fallthrough
Yggdrasil.cpp:
Fix case fallthrough
AccountList.cpp:
Fix case fallthrough,
WinDarkmode.cpp:
Add an explanation and fix warnings due to FARPROC casts.
Signed-off-by: jdp_ <42700985+jdpatdiscord@users.noreply.github.com>
The mechanism that both pack updating and Modrinth overrides use utilize std::filesystem::copy, which with GCC's libstdc++ has a bug on Windows where `overwrite_existing` isn't obeyed. In addition, made it clear what `overrideFolder` does by renaming it and rewriting an error message.
This simple commit adds the ability to further customize the cat by
allowing the user to change its position.
Signed-off-by: xSlendiX <slendi@socopon.com>
How can we have a cat selection combo box without a floppa option?!
This is unacceptable, and this patch fixes it. Now the launcher can flop
all day long :^)
Signed-off-by: xSlendiX <slendi@socopon.com>
This patch adds a nice little pie chart to visually show which parts of
the instance take most space. It also refactors some code and improve
the UX a bit more.
Signed-off-by: xSlendiX <slendi@socopon.com>
This patch adds a new page to instance settings which allows users to
manage storage. This commit represents the start of it. Right now, only
some base features are implemented.
Signed-off-by: xSlendiX <slendi@socopon.com>
Also changes the "No accounts available" message to be placeholder text
instead of a combobox item, if the current Qt version supports it.
Signed-off-by: Lenny McLennington <lenny@sneed.church>
Also needed to add a call to loop.exit() in FlameInstanceCreationTask so
that it would handle the failure of FileResolvingTask properly
Signed-off-by: Lenny McLennington <lenny@sneed.church>
This should allow people to use Curseforge without having to manually
paste a working key into the settings or change the user agent.
Signed-off-by: Lenny McLennington <lenny@sneed.church>
